Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Mac OS X and *BSD support #221

Merged
merged 56 commits into from
Dec 2, 2016
Merged

Native Mac OS X and *BSD support #221

merged 56 commits into from
Dec 2, 2016

Conversation

guedou
Copy link
Member

@guedou guedou commented Jul 15, 2016

This PR provides native support for Mac OS X and and *BSD. No external Python
modules are required to send and receive packets. It was tested on Debian, OS X 10.9.5, FreeBSD 10.2, NetBSD 7.0 and OpenBSD 5.5

Issue #104 provides some examples, as well as several mandatory items that were
implemented and tested.

@p-l- I chose to keep all commits for reference, as some changes are not
obvious. Can you squash them when the PR is OK ? Thanks.

@guedou
Copy link
Member Author

guedou commented Aug 8, 2016

@p-l the PR is finally good to be review. When you are OK with it, could you squash them all commits into a single one named "Native BPF support". We might face a merging issue after accepting PR #258.

@guedou guedou mentioned this pull request Aug 24, 2016
@guedou
Copy link
Member Author

guedou commented Oct 26, 2016

@p-l- hopefully the travis run will go fine. The patch is good to be "squashed and merged"

@p-l-
Copy link
Member

p-l- commented Nov 22, 2016

I'm not sure what is wrong here, but this Travis CI test should not pass, should it?

@guedou
Copy link
Member Author

guedou commented Nov 22, 2016 via email

@p-l-
Copy link
Member

p-l- commented Nov 22, 2016

$ bash .travis/test.sh
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "scapy/all.py", line 16, in <module>
    from scapy.arch import *
  File "scapy/arch/__init__.py", line 81, in <module>
    from scapy.arch.bpf import *
  File "scapy/arch/bpf.py", line 9, in <module>
    from scapy.arch.bsd import LOOPBACK_NAME
ImportError: No module named bsd

But the test still "passes", so we should probably change the return code here.

@guedou
Copy link
Member Author

guedou commented Nov 22, 2016

Thanks. I accessed the Travis test with a mobile phone and could not see the log. I pushed a patch that hopefully will fix the issue. I wonder why Travis displayed the test as OK.

@guedou
Copy link
Member Author

guedou commented Nov 22, 2016

@p-l- I have a lot of errors due to modification to consts.py =/

@guedou
Copy link
Member Author

guedou commented Nov 23, 2016 via email

@guedou
Copy link
Member Author

guedou commented Nov 24, 2016

@p-l- it seems that the OS X tests stopped working with PR #342, see https://travis-ci.org/secdev/scapy/builds/174817909 and https://travis-ci.org/secdev/scapy/jobs/174817912

@guedou guedou mentioned this pull request Nov 24, 2016
@p-l- p-l- merged commit 35f97ef into secdev:master Dec 2, 2016
gpotter2 pushed a commit to gpotter2/scapy that referenced this pull request Dec 10, 2016
@guedou guedou deleted the scapy_bpf branch September 11, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants