Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated import #1707

Merged
merged 2 commits into from
Nov 18, 2018
Merged

Conversation

carlbordum
Copy link
Contributor

from collections import Iterable was removed in Python 3.8

@codecov-io
Copy link

codecov-io commented Nov 18, 2018

Codecov Report

Merging #1707 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   85.38%   85.38%   -0.01%     
==========================================
  Files         180      180              
  Lines       42003    42006       +3     
==========================================
- Hits        35866    35865       -1     
- Misses       6137     6141       +4
Impacted Files Coverage Δ
scapy/layers/dhcp.py 87.34% <100%> (+0.16%) ⬆️
scapy/automaton.py 81.84% <0%> (-0.56%) ⬇️
scapy/layers/ntp.py 91.51% <0%> (-0.27%) ⬇️
scapy/layers/inet6.py 88.32% <0%> (+0.05%) ⬆️

@gpotter2 gpotter2 merged commit 807168b into secdev:master Nov 18, 2018
@gpotter2
Copy link
Member

Thanks for pointing that out !

We only support released python versions (2.7 and 3.4-3.7) but that’s future proof :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants