New read_routes6() function and unit tests #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an attempt at fixing Issue #109 by rewriting scapy.unix.read_routes6().
This patch provides mocked tests that ease reproducing outputs on several
operating systems. Scapy tests from regression.uts were also tested on real OS. I can not swear that this patch does not introduce any regressions or bugs by itself, but I tried my best not to.
read_routes6()
can be tested as follows:It could be interesting to extend the idea mocked_functions.py to other part of
Scapy, and to run this tests with Travis along with the classic regression tests.