🔧 Fix recently introduced code regressions #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, two regressions were introduced as a compromise:
react-native
) #42 (comment)react-native
) #42 (comment)Now, both regressions are fixed.
Testing
npm run test
should be ✅npm run start
Additional information
For
App/index.tsx
I decided to use aninitialReady
props only for tests (so it's set tofalse
if not present, for same behavior as what the app used to do). I could also have added an&& process.env['NODE_ENV'] !== 'test'
condition to the short-circuit (instead) but I find it a bit dirty. Reason behind all of it is that it looks difficult to simulateuseEffect
withreact-native
+ the testing library (note: I tried outrerender
to no luck): testing-library/react-testing-library#215