Explicitly assert on badged errors instead of ignoring badged errors @eps1lon #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is attached to our custom Error "sub class" on the receiving side which also includes digest. DEV-only.
This way this helper can use component stacks when available.
That way your typical log of an error that originated on the Server gets a `[Server]` badge. Unfortunately because defaultOnUncaughtError and defaultOnRecoverableError doesn't use custom logging but goes through reportError. There's no place for us to add this kind of formatted badging to the logs. It's also unfortunate that you'd have to replicate this in user space.
eps1lon
commented
Jun 19, 2024
| @@ -841,6 +841,10 @@ describe('ReactFlightDOM', () => { | |||
| expectedGamesValue, | |||
| ); | |||
|
|
|||
| if (gate(flags => flags.enableOwnerStacks)) { | |||
There was a problem hiding this comment.
I was expecting enableServerComponentLogs but the behavior is not actually behind this flag. Using enableServerComponentLogs would fail CI.
eps1lon
commented
Jun 19, 2024
| @@ -841,6 +841,10 @@ describe('ReactFlightDOM', () => { | |||
| expectedGamesValue, | |||
| ); | |||
|
|
|||
| if (gate(flags => flags.enableOwnerStacks)) { | |||
| // TODO: assertConsoleServerErrorDev | |||
There was a problem hiding this comment.
Probably best to use a dedicated assertConsoleBadgedErrorDev matcher with the badge name. That way we could also test switching environment names halfway through.
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.