Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix icon style buttons alignment #196

Merged
merged 3 commits into from
Jun 9, 2024
Merged

style: fix icon style buttons alignment #196

merged 3 commits into from
Jun 9, 2024

Conversation

MichaHuhn
Copy link

@MichaHuhn MichaHuhn commented Jun 9, 2024

This PR fixes the alignment of the icon style buttons.
The rest of the discussed style fixes can be implemented on top of this PR after it's merged.

Before:
before1 before2

After:

after


I don't have access to some FontAwesome icons. That's why some icons are broken in the screenshot.

The GitHub diff screen doesn't show the changes completely accurate. I only adjusted a bit of HTML and CSS. It's not as much as it looks like.

Copy link
Owner

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this fast PR! This fixes the width and the formatting issues, the remaining issue is due to the layout which I can fix myself. You can get sub in the next stream, as promised ;)

@sebinside sebinside merged commit d19d9e8 into sebinside:preset-support Jun 9, 2024
@sebinside sebinside added the bug Something isn't working label Jun 9, 2024
@sebinside sebinside added this to the v3.0.0 milestone Jun 9, 2024
@MichaHuhn MichaHuhn deleted the style/fix-icon-style-buttons-alignment branch June 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants