Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginning changes to RC6 #606

Closed
wants to merge 9 commits into from
Closed

Beginning changes to RC6 #606

wants to merge 9 commits into from

Conversation

timwright35
Copy link
Contributor

Modified the code to work in RC6, there are two TS errors about Provider though so gulp test fails. I have run the code in my project though and it loads and runs fine, so I have slightly lost on that.

@GitCop
Copy link

GitCop commented Sep 1, 2016

There were the following issues with your Pull Request

  • Commit: 80a7a40
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@timwright35 timwright35 mentioned this pull request Sep 1, 2016
@GitCop
Copy link

GitCop commented Sep 1, 2016

There were the following issues with your Pull Request

  • Commit: 80a7a40
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@timwright35
Copy link
Contributor Author

Apparently I do not know how to format my commit name

@sebholstein
Copy link
Owner

@Tempus35 sorry, I didn't see that you are working on RC6 (and pushed some features in the meantime).

Can you rebase your commit (and fix the conflict)? A good commit message would be:

feat(*): support angular RC6

Let me know if you don't have time to complete this today. I want to release a version with RC6 support as soon as possible.
Thanks!

@@ -4,6 +4,12 @@
* @link https://github.com/SebastianM/angular2-google-maps#readme
* @license MIT
*/
/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is a dup. please remove it. thanks

@GitCop
Copy link

GitCop commented Sep 1, 2016

There were the following issues with your Pull Request

  • Commit: 80a7a40
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Sep 1, 2016

There were the following issues with your Pull Request

  • Commit: 80a7a40
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@timwright35
Copy link
Contributor Author

Ok I apparently do not know how to rebase, any help. I made the changes above you gave though

@sebholstein
Copy link
Owner

sebholstein commented Sep 1, 2016

Ok, I'll try to help you. First, we need to make sure that there are no conflicts any more.

Try to run this:

git pull upstream --rebase
git merge upstream/master

Then, you have to fix the conflicts and commit the changes (and push it to your origin).

When everything is fine, we can work on the rebase (to squash it to one commit). Hope this helps

@timwright35
Copy link
Contributor Author

So no clue what I did but the first command is not working at all, one it says rebase is not an option and even without rebase it still does not work.

@sebholstein
Copy link
Owner

Oh, my bad. Try to run just git pull --rebase (and fix the conflicts)

@timwright35
Copy link
Contributor Author

From https://github.com/Tempus35/angular2-google-maps

  • branch master -> FETCH_HEAD
    Current branch master is up to date.

Gave me the above

@sebholstein
Copy link
Owner

Ok, sorry Tim, this is really hard to debug from here. Maybe it's easier when you send a new PR (because the merge conflicts will be hard to fix).

@timwright35
Copy link
Contributor Author

Yea I was thinking the same things, I will close this one and send a new one with the right stuff from the beginning.

@timwright35 timwright35 closed this Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants