refactor: tslint cleanup #1704
Merged
refactor: tslint cleanup #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
terencehonles
force-pushed
the
fix-tslint
branch
2 times, most recently
from
a7fd976 to
3af5f65
Compare
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
==========================================
- Coverage 47.23% 47.17% -0.06%
==========================================
Files 41 41
Lines 1806 1808 +2
Branches 166 166
==========================================
Hits 853 853
- Misses 950 952 +2
Partials 3 3
Continue to review full report at Codecov.
|
terencehonles
force-pushed
the
fix-tslint
branch
from
3af5f65 to
3e83069
Compare
|
I'll look it it. It's just a lot of changes, so may take me some time |
ghost
suggested changes
Aug 26, 2019
|
|
||
| export function createMVCEventObservable<T>(array: MVCArray<T>): Observable<MVCEvent<T>>{ | ||
| const eventNames = ['insert_at', 'remove_at', 'set_at']; | ||
| return fromEventPattern( | ||
| (handler: Function) => eventNames.map(evName => array.addListener(evName, | ||
| (index: number, previous?: T) => handler.apply(array, [ {'newArr': array.getArray(), evName, index, previous} as MVCEvent<T>]))), | ||
| (handler: Function, evListeners: MapsEventListener[]) => evListeners.forEach(evListener => evListener.remove())); | ||
| (_handler: Function, evListeners: MapsEventListener[]) => evListeners.forEach(evListener => evListener.remove())); |
There was a problem hiding this comment.
why is this renamed? i kept it the same, so it matches its sibling parameter
There was a problem hiding this comment.
TSlint was complaining that it was unused and only didn't complain when it was prefixed with a "_"
terencehonles
force-pushed
the
fix-tslint
branch
from
2c65e15 to
e1516a9
Compare
|
@doom777 I made some updates to the PR based on your requests. |
ghost
approved these changes
Sep 1, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure tslint properly + add some more checks and run
yarn lint --fixto fix most and manually fix the rest.For old branches/PRs run
git checkout 3af5f65 package.json tslint.json && yarn && yarn lint --fixand the branch should be easier to merge w/ these changes.