Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Rectangle functionality #1206

Closed
wants to merge 2 commits into from
Closed

Added Rectangle functionality #1206

wants to merge 2 commits into from

Conversation

timhovius
Copy link
Contributor

@timhovius timhovius commented Oct 18, 2017 •
edited
Loading

Rectangle functionality 😄

#570

@timhovius timhovius force-pushed the rectangle branch 3 times, most recently from 016fd3c to b9e1c6f Compare October 18, 2017 19:13
@timhovius timhovius changed the title Rectangle Added Rectangle functionality Oct 18, 2017
@sebholstein
Copy link
Owner

wow, thx @timhovius ! Can you add some unit tests? Thx for your time

@timhovius
Copy link
Contributor Author

Yes I'll do that tonight 😉

@timhovius
Copy link
Contributor Author

Unit tests added 👍

@timhovius timhovius force-pushed the rectangle branch 3 times, most recently from f5f6816 to 270cfe8 Compare December 2, 2017 18:46
@timhovius
feat(Rectangle)
d697453 
add rectangle functionality
timhovius
timhovius commented Dec 18, 2017
View reviewed changes
Copy link
Contributor Author

@timhovius timhovius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ready to merge

timhovius
timhovius commented Dec 18, 2017
View reviewed changes
Copy link
Contributor Author

@timhovius timhovius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ready for merge

@hartherbert
Copy link

what about the merge? is that going to happen ?

@sebholstein sebholstein mentioned this pull request Jul 4, 2018
Merged
@sebholstein
Copy link
Owner

we track this in #1450

@sebholstein sebholstein closed this Jul 4, 2018
@tauqeer81
Copy link

Could anyone explain how to use <agm-rectangle></agm-rectangle>.
I'm having this issue.

Can't bind to 'north' since it isn't a known property of 'agm-rectangle'.
1. If 'agm-rectangle' is an Angular component and it has 'north' input, then verify that it is part of this module.

any help or feedback will be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timhovius timhovius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timhovius @sebholstein @hartherbert @tauqeer81