fix(dataLayer): only update those data options which were changed #1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1099 and probably similar issues, where updating the data of a data layer causes all data options to be cleared, because they are not passed along, hence
null
is passed in as a value tosetControlPosition
etc, instead of the actual values.Note that this will obviously prevent actually clearing these 'data options' by setting them to null, but fixing this would require further refactoring.