Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The generated file core.umd.js is not ES5 #783

Closed
vandres opened this issue Dec 12, 2016 · 3 comments
Closed

The generated file core.umd.js is not ES5 #783

vandres opened this issue Dec 12, 2016 · 3 comments

Comments

@vandres
Copy link

vandres commented Dec 12, 2016

Issue description
When installing angular2-google-maps via npm, the file core.umd.js is not ES5.

Expected/desired behavior
core.umd.js is ES5 to support older devices

angular2 & angular2-google-maps version
latest stable
@lverledens
Copy link

This would be a really nice patch. The package currently is unusable on CentOS 6.x.

sebholstein added a commit that referenced this issue Dec 16, 2016
@sebholstein
fix(core.umd.js): ship ES5 compatible UMD file
6abfc5b 
The UMD file was not ES5 compatible.

Fixes #783

BREAKING CHANGE:
The files under `/esm` are ES5 (before: ES2015) based with ES2015 modules.
In the real world, this should not cause troubles.
@sebholstein sebholstein mentioned this issue Dec 16, 2016
Merged
sebholstein added a commit that referenced this issue Dec 16, 2016
@sebholstein
fix(core.umd.js): ship ES5 compatible UMD file
c81a15f 
The UMD file was not ES5 compatible.

Fixes #783

BREAKING CHANGE:
The files under `/esm` are ES5 (before: ES2015) based with ES2015 modules.
In the real world, this should not cause troubles.
@vandres
Copy link
Author

vandres commented Dec 16, 2016 •
edited
Loading

@SebastianM So is the docu still valid?

  1. The files located in the root dir are ES5 compatible files that can be consumed using CommonJS..
  2. The files under /esm are ES5 based with ES2015 modules.

@sebholstein
Copy link
Owner

Yes,

see commit msg:

The files under `/esm` are ES5 (before: ES2015) based with ES2015 modules.
In the real world, this should not cause troubles.

@DavidGangel DavidGangel mentioned this issue Dec 31, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebholstein @vandres @lverledens