Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Add method to calendar in quickstart example #535

Merged

Conversation

Justin-Koningsberger
Copy link
Contributor

About this Pull Request

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    • Updates the README to include a method in the calendar object, so outlook displays the invitation properly. Without it there are no accept/decline buttons shown, and the filename is "calendar not supported message.ics".
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    • No
  • Other information:

Pull Request Checklist

  • My code follows the code style of this project
    • Run npm run lint to double check
  • My change requires a change to the documentation
    • I have updated the documentation accordingly
  • I have added tests to cover my changes
    • Run npm run test to run the unit tests and npm run coverage to generate a coverage report
  • All new and existing tests passed
  • My commit messages follow the commit guidelines

README.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastian <[email protected]>
@sebbo2002 sebbo2002 changed the title Add a method to the calendar in the quickstart example docs(README): Add method to calendar in quickstart example Oct 29, 2023
@sebbo2002 sebbo2002 merged commit f536105 into sebbo2002:develop Oct 29, 2023
7 checks passed
@sebbo2002
Copy link
Owner

🎉 This PR is included in version 6.0.1-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebbo2002
Copy link
Owner

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants