Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no default imports #134

Closed
wants to merge 1 commit into from
Closed

Fix no default imports #134

wants to merge 1 commit into from

Conversation

g-ongenae
Copy link
Contributor

The current default imports throw those errors:

node_modules/ical-generator/index.d.ts(5,10): error TS1192: Module '"/usr/src/app/node_modules/moment/moment"' has no default export.
node_modules/ical-generator/index.d.ts(6,10): error TS1192: Module '"http"' has no default export.

@g-ongenae
Copy link
Contributor Author

Fix it with the use of allowSyntheticDefaultImports option.
See microsoft/TypeScript#3337 (comment)

@g-ongenae g-ongenae closed this Dec 27, 2018
@g-ongenae g-ongenae deleted the fix/imports branch December 27, 2018 16:32
@evelynhathaway
Copy link
Contributor

Actually, that's a good point. I have "esModuleInterop": true on in my tsconfig.json and esModuleInterop implicitly adds allowSyntheticDefaultImports (TIL) which is why I missed those errors while I was converting to default imports as VSCode suggested.

So, I'll create another PR co-authoring with you to explicitly collect the entire module into their bindings.

@evelynhathaway evelynhathaway mentioned this pull request Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants