Allow setting GEO by making ICalLocation.title optional
#578
Assignees
Comments
Merged
github-actions bot
pushed a commit
that referenced
this issue
Feb 22, 2024
# [7.0.0-develop.1](v6.0.2-develop.13...v7.0.0-develop.1) (2024-02-22) ### Bug Fixes * fixed GEO missing when supplied (closes [#569](#569)) ([2eeceb8](2eeceb8)) * fixed typo `&&&` to `&&` ([7707b59](7707b59)) ### Features * **Event:** Made `ICalEvent.location.title` optional to allow setting `GEO` without title ([42be230](42be230)), closes [#578](#578) ### BREAKING CHANGES * **Event:** [ICalEvent.location()](https://sebbo2002.github.io/ical-generator/develop/reference/classes/ICalEvent.html#location)'s `title` field can now be undefined
|
🎉 This issue has been resolved in version 7.0.0-develop.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this issue
Mar 17, 2024
# [7.0.0](v6.0.1...v7.0.0) (2024-03-17) ### Bug Fixes * **Event:** Run start/end validation only when getting data ([9174a32](9174a32)), closes [#581](#581) * fixed GEO missing when supplied (closes [#569](#569)) ([2eeceb8](2eeceb8)) * fixed typo `&&&` to `&&` ([7707b59](7707b59)) ### Features * **Alarm:** Add support for `email` alarm type ([5398f09](5398f09)), closes [#576](#576) * **Event:** Made `ICalEvent.location.title` optional to allow setting `GEO` without title ([42be230](42be230)), closes [#578](#578) ### BREAKING CHANGES * **Event:** [ICalEvent.location()](https://sebbo2002.github.io/ical-generator/develop/reference/classes/ICalEvent.html#location)'s `title` field can now be undefined
|
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is currently not possible to enter a location without specifying a
title:ical-generator/src/types.ts
Lines 22 to 27 in f27dd10
This means that 'GEO' cannot be set if there is no title. This should be changed. See also #569 and #570. I currently assume that this will be a breaking change, as the return values of the
location()getter will change, astitlecan now be optional.The text was updated successfully, but these errors were encountered: