Types are not compatible with Luxon 3.3 not in strict mode

[zackdotcomputer]

Essentially a reopen of #482 because that got closed without maintainer response or resolution.

The current ICalLuxonDateTimeStub is not compatible with [email protected]'s DateTime object if the system is not overridden to be in "strict mode". This is generally an issue with how Luxon has chosen to implement this new feature, but for the purposes of the ical-generator it feels like the system should accept non-strict DateTime objects.

The issue shows up with:

cal.createEvent({
      // These two values throw an error if using non-strict Luxon DateTime
      start,
      end,
      // Rest of args...
});

The specific error is:

Type 'DateTime' is not assignable to type 'ICalDateTimeValue | { (): ICalDateTimeValue | null; (start: ICalDateTimeValue): ICalEvent; } | null | undefined'.
  Type 'DateTime' is not assignable to type 'ICalLuxonDateTimeStub'.
    The types returned by 'toJSON()' are incompatible between these types.
      Type 'string | null' is not assignable to type 'string'.
        Type 'null' is not assignable to type 'string'.ts(2322)

[sebbo2002]

Thanks for the ticket, completely missed this at #482. I probably won't get to it until next week, thanks for your understanding.

[sebbo2002]

🎉 This issue has been resolved in version 4.1.0-develop.3 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release
• v4.1.0-develop.3

Your semantic-release bot 📦🚀

[sebbo2002]

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release
• v4.1.0

Your semantic-release bot 📦🚀