Make @types/node an optional peer dependency #244
Comments
adamreisnz
changed the title
|
Sure, think that also applies for the other peerDependencies, but I have to double check later… |
Merged
sebbo2002
pushed a commit
that referenced
this issue
Apr 17, 2021
# [2.0.0-develop.21](v2.0.0-develop.20...v2.0.0-develop.21) (2021-04-17) ### Bug Fixes * Make peer dependencies optional ([b384ac7](b384ac7)), closes [#244](#244)
|
🎉 This issue has been resolved in version 2.0.0-develop.21 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Cheers thank you
…On Sun, 18 Apr 2021, 00:43 Sebastian, ***@***.***> wrote:
🎉 This issue has been resolved in version 2.0.0-develop.21 🎉
The release is available on:
- npm package ***@***.*** dist-tag)
<https://www.npmjs.com/package/ical-generator/v/2.0.0-develop.21>
- GitHub release
<https://github.com/sebbo2002/ical-generator/releases/tag/v2.0.0-develop.21>
- v2.0.0-develop.21
Your *semantic-release
<https://github.com/semantic-release/semantic-release>* bot 📦🚀
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADXYQS6PX4AK5IWKIFPR5DTJF65ZANCNFSM43CU4C6A>
.
|
sebbo2002
pushed a commit
that referenced
this issue
Apr 28, 2021
# [2.0.0](v1.15.4...v2.0.0) (2021-04-28) ### Bug Fixes * **package.json:** add temporary version ([0bc117e](0bc117e)) * Allow to set null values within object constructors ([8b87183](8b87183)) * **deps:** Also define libs as devDependency for tests ([c04ae32](c04ae32)) * **deps:** Define supported libs as peerDependencies ([84e2784](84e2784)) * Make peer dependencies optional ([b384ac7](b384ac7)), closes [#244](#244) * **Tools:** Prevent formatDate() from using global timezones prefixed with a slash ([85ab7b2](85ab7b2)) * **deps:** Put necessary typings in peerDependencies as well :/ ([14f0f43](14f0f43)) * **Event:** Remove `moment` dependency in constructor ([8331d4c](8331d4c)), closes [#234](#234) ### Code Refactoring * **Calendar:** Remove moment.Duration from `ttl()` method ([c6ccd12](c6ccd12)) * Update error URLs ([2aedf55](2aedf55)) ### Features * **Event:** Add `priority()` method ([247039f](247039f)), closes [#163](#163) * **Attendee:** Add `x()` method for custom attributes ([5d9d686](5d9d686)), closes [#183](#183) * **Calendar:** add new clear method ([1ebefcb](1ebefcb)), closes [#188](#188) * Add ReleaseBot ([2fba164](2fba164)) * **Calendar:** Add support for external VTimezone generator ([f4bc8e0](f4bc8e0)), closes [#122](#122) * **Event:** Allow `X-APPLE-STRUCTURED-LOCATION` without address ([4e63e29](4e63e29)), closes [#236](#236) * **Event:** Make organizer.email optional ([8450492](8450492)), closes [#137](#137) * **Event:** Merge `location()`, `appleLocation()` and `geo()` ([62c1516](62c1516)), closes [#187](#187) * Merge event's `description()` and `htmlDescription()` ([ce537f8](ce537f8)) * Support moment.js, Day.js and Luxon ([#91](#91), BREAKING CHANGE) ([6db24ee](6db24ee)) * **Event:** Support RRule objects and raw strings in `repeating()` ([4436785](4436785)), closes [#190](#190) * Updated the entire codebase to Typescript ([d013dc0](d013dc0)) * **Events:** Use uuid-random for random UUIDs (close [#215](#215)) ([a4c19cc](a4c19cc)) ### BREAKING CHANGES * Some error messages changed, so if you check for error , please double check them now. * `htmlDescription()` was removed, use `description()` instead. * **Calendar:** `ttl()` will now return a number, not a `moment.Duration`. You can still use `moment.Duration` to set the `ttl` value. * **Event:** `geo()` and `appleLocation()` are not available anymore, use `location()` instead and pass an location object (with title, radius, etc.) * **Calendar:** Calendar's `clear()` method is a completely new implementation and, unlike previous versions, will not reset metadata such as `name` or `prodId`. Only the events will be removed
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can this be made an optional peer dependency?
We don't use TypeScript and don't want to add bloat to our project by including this as a dependency.
Everything is working fine without this dependency, so can it be made optional so that we avoid the errors?
warning " > [email protected]" has unmet peer dependency "@types/node@>= 8.0.0".The text was updated successfully, but these errors were encountered: