Fix identifier parser regression (#183)

sebastienros · Dec 9, 2024 · 9d9dc58 · 9d9dc58
1 parent b2f7808
commit 9d9dc58
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/Parlot/Character.Class.cs b/src/Parlot/Character.Class.cs
@@ -12,6 +12,6 @@ public static partial class Character
     public const string AZ = AZLower + AZUpper;
     public const string AlphaNumeric = AZ + DecimalDigits;
     public const string DefaultIdentifierStart = "$_" + AZ;
-    public const string DefaultIdentifierPart = "$_" + AZ;
+    public const string DefaultIdentifierPart = "$_" + AZ + DecimalDigits;
     public const string NewLines = "\n\r\v";
 }
diff --git a/test/Parlot.Tests/CompileTests.cs b/test/Parlot.Tests/CompileTests.cs
@@ -407,6 +407,9 @@ public void ShouldCompileWhiteSpace()
     [InlineData("$_", "$_")]
     [InlineData("a-foo.", "a")]
     [InlineData("abc=3", "abc")]
+    [InlineData("abc3", "abc3")]
+    [InlineData("abc123", "abc123")]
+    [InlineData("abc_3", "abc_3")]
     public void CompiledIdentifierShouldParseValidIdentifiers(string text, string identifier)
     {
         Assert.Equal(identifier, Literals.Identifier().Compile().Parse(text).ToString());

diff --git a/test/Parlot.Tests/FluentTests.cs b/test/Parlot.Tests/FluentTests.cs
@@ -383,6 +383,9 @@ public void SwitchShouldReturnCommonType()
     [InlineData("$_", "$_")]
     [InlineData("a-foo.", "a")]
     [InlineData("abc=3", "abc")]
+    [InlineData("abc3", "abc3")]
+    [InlineData("abc123", "abc123")]
+    [InlineData("abc_3", "abc_3")]
     public void IdentifierShouldParseValidIdentifiers(string text, string identifier)
     {
         Assert.Equal(identifier, Literals.Identifier().Parse(text).ToString());