Trim = from Base64UrlSafeEncode #691
Conversation
Fluid/Filters/MiscFilters.cs
Outdated
| @@ -196,7 +196,7 @@ public static ValueTask<FluidValue> Base64UrlSafeEncode(FluidValue input, Filter | |||
| encodedBase64StringBuilder.Replace('+', '-'); | |||
| encodedBase64StringBuilder.Replace('/', '_'); | |||
|
|
|||
| return new StringValue(encodedBase64StringBuilder.ToString()); | |||
| return new StringValue(encodedBase64StringBuilder.ToString().TrimEnd('=')); | |||
There was a problem hiding this comment.
Does the string builder have something like it? That would prevent the extra string allocation.
There was a problem hiding this comment.
If we know that base64 encoded version ends with == (it should) it should suffice to encodedBase64StringBuilder.Length -= 2;
There was a problem hiding this comment.
That's a good option too
There was a problem hiding this comment.
It's not always the case, could be zero, one or two chars. See the test cases I shared for instance.
There was a problem hiding this comment.
But I see what you mean now, sorry.
There was a problem hiding this comment.
The issue that might be raise during decoding how we know there was zero, one or two "=" on the encoded URL?
There was a problem hiding this comment.
FYI there's Base64.IsValid() introduced in .NET 8.0 but it will not solve the problem in our case
|
Feel free to merge when you add the test, thanks. |
|
Sure, I will add a test then merge |
|
Added the same tests to ensure the decoding was fine too and it happens it was not as the Took the time to implement @lahma 's suggestion to skip the string allocation. |
Fixes #690