Replace custom attribute shims with PolySharp #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adams85
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
As long as it's a dev-time dependency, I don't have too strong concerns for adding a 3rd party dependency. The lib and its author look solid, so I have nothing against it.
I just suggest we are explicit about the included polyfills, that is, let's include only those which are really needed. (Sorry for meddling with your PR, was quicker this way for me. Just drop my commit if you disagree.)
|
Thanks, explicit looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the original reasoning to have own versions of the attribute shims due to concerns about supply chain attacks, I would argue that we can trust in the author of PolySharp who is a well recognized Microsoft employee. This would also gives us many other missing bits if we ever needed them. Thoughts?