Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement top-level await in modules feature #361

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Conversation

adams85
Copy link
Collaborator

@adams85 adams85 commented Dec 28, 2022

No description provided.

@lahma
Copy link
Collaborator

lahma commented Dec 28, 2022

Can you also remove the feature exclude from test262 settings and make sure test cases pass?

@adams85
Copy link
Collaborator Author

adams85 commented Dec 28, 2022

Sure, it's done. We have 4 failing test cases in test262 but those aren't related to this feature and will be fixed by #356. We can merge this PR after that.

Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@adams85 adams85 merged commit 0828a8b into main Dec 29, 2022
@adams85 adams85 deleted the feature/top-level-await branch December 29, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants