-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a few bugs in parser (#292) #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adressing also parsing bugs, help is really needed on this area. Looks good to my eye.
Ready to merge? |
BTW, acorn source code is also a good reference for parsing some constructs, pretty neat code base. |
Yeah, it's ready. |
@adams85 hopefully you got an invite as collaborator to this repository and you can do a bit more without us blocking you. If change looks OK to you and not too risky, act like you wish. PR peer review might be good for bigger changes but if people are unavailable, don't hesitate to use your own judgement. |
I got the invitation, thanks for the confidence! As a matter of fact, there are still a few things which would be nice to set straight for v3. Now it will definitely be smoother to make those changes. |
Standard process is to not use a fork, just create local task branches, and when a PR is merged the branch is deleted (automatically). If you prefer forks feel free to continue though. I don't. |
Aims to resolve #292. There were more problems around decorators than it looked at first. Hopefully, this would fix them all.