Fix some numeric parsing related issues #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
numeric-parsing-fixes
branch
from
f7c528c
to
efba276
Compare
sebastienros
approved these changes
Apr 12, 2022
lahma
force-pushed
the
numeric-parsing-fixes
branch
2 times, most recently
from
93cde0c
to
1aa83b4
Compare
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First tried to fix some numeric separator issues but started to be bit of yak shaving.
Found out that the tolerant logic in options was wrong, tests should be run with Tolerant = false to enforce proper parsing rules. Changed that and did required fixes. Options are still Tolerant = true by default as it would be a breaking change to change that.
Some errors are easiest to handle on Scanner level so supplied more information to Scanner for it to know with error should be thrown (are we in strict mode or not, are we allowing escaped identifier names like for object properties which is allowed).
Deleted couple old test cases which are not meant to throw based on my nodejs testing.
allow-list.txt should be a good indicator for changes, almost 2000 lines removed, some lines added like top level await (which hasn't been implemented).