Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested arrays #48

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

hammo92
Copy link
Collaborator

@hammo92 hammo92 commented Jul 15, 2024

There were issues with array definitions caused by the duplicate field definitions in the schema returned from SurrealDB

roles: 'DEFINE FIELD roles ON organisation TYPE array<record<role>> DEFAULT [] PERMISSIONS FULL',
'roles[*]': 'DEFINE FIELD roles[*] ON organisation TYPE record<role> PERMISSIONS FULL'

The new implementation should fix the issue. Have added some more comprehensive tests for the schema generation.

Should fix #46 and #47

@sebastianwessel
Copy link
Owner

lgtm.
Will merge tonight and publish new release

@sebastianwessel sebastianwessel merged commit 21e6c03 into sebastianwessel:main Jul 15, 2024
1 check passed
@hammo92 hammo92 deleted the nestedArrays branch July 16, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Object array test is wrong
2 participants