Refactoring of TestRunner, TestSuite #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filters can be used to iterate over TestSuite allowing to simplify group/exclude-group options handling
-added Filters injection in TestRunner -refactor TestSuite::run
|
Thanks for the pull request! The issue you indent to solve are something I'd like to get rid of for a long time so I'm really grateful that you took the time to look into that. As this will take a little more effort in BC testing and looking into it I can't promise you when me or sebastian will have time. Just wanted to respond :) |
|
"Thanks!" from me as well. Hopefully I'll find some time soon to review. |
sebastianbergmann
added a commit
that referenced
this pull request
Jan 26, 2013
This was referenced Mar 9, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Could you please check my implementation of Filters system and refactoring of TestSuite?
It is intended to fix #541 and #261.
Also I hope that later it can be used as a part of #10
Thanks in advance