Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON object order comparision with numeric keys #4675

Closed
wants to merge 10 commits into from
Closed

Fix JSON object order comparision with numeric keys #4675

wants to merge 10 commits into from

Conversation

Firehed
Copy link
Contributor

@Firehed Firehed commented May 19, 2021 •
edited
Loading

Fixes #4584, fixes #4674

@codecov
Copy link

codecov bot commented May 19, 2021 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (638c105) to head (aec46c1).
Report is 6118 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4675   +/-   ##
=========================================
  Coverage     83.68%   83.68%           
- Complexity     4944     4945    +1     
=========================================
  Files           389      389           
  Lines         13126    13129    +3     
=========================================
+ Hits          10984    10987    +3     
  Misses         2142     2142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed marked this pull request as ready for review May 20, 2021 00:21
@sebastianbergmann sebastianbergmann added feature/assertion Issues related to assertions and expectations type/bug Something is broken labels May 20, 2021
@sebastianbergmann sebastianbergmann force-pushed the main branch 3 times, most recently from 08dc555 to 63591f3 Compare December 23, 2023 09:32
@sebastianbergmann
Copy link
Owner

I am sorry that it took me so long to review this. Can you please resolve the conflicts and target the 10.5 branch? Thanks!

@kubawerlos kubawerlos mentioned this pull request Sep 7, 2024
Merged
@Firehed Firehed deleted the json-dict-order branch September 10, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/assertion Issues related to assertions and expectations type/bug Something is broken
Projects
None yet
Milestone
No milestone
2 participants
@Firehed @sebastianbergmann