Throw exception on non unique mocked method

[jaapio]

This patch will make a mock throw an exception when multiple matchers
can be applied to a invoke. When allowing this, the results of tests are
not predictable.

In preparation on #4255 I found that a test case like the one below would never pass. Because the written test is just wrong. However, the mocking framework does allow this. But does not handle it properly. From now on an exception will be thrown.

        $mock->expects($this->any())
            ->method($this->stringStartsWith('foo'))
            ->with('foo')
            ->willReturn('result');

        $mock->expects($this->any())
            ->method('foo')
            ->with('bar')
            ->willReturn('result');

refs #4255

[codecov]

Codecov Report

Merging #4258 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #4258      +/-   ##
============================================
- Coverage     84.26%   84.22%   -0.05%     
- Complexity     4526     4527       +1     
============================================
  Files           218      218              
  Lines         11101    11103       +2     
============================================
- Hits           9354     9351       -3     
- Misses         1747     1752       +5     

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/MockObject/InvocationHandler.php	69.84% <66.66%> (-7.21%)	27.00 <6.00> (+1.00)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f7c75...e860ff4. Read the comment docs.

[sebastianbergmann]

Cherry-picked into 9.2 and merged from there. Thanks!

[GrahamCampbell]

This change broke laravel/framework's test suite.

[GrahamCampbell]

1) Illuminate\Tests\Database\DatabaseConnectionTest::testBeginTransactionMethodRetriesOnFailure
Non unique mocked method invocation: PDO::beginTransaction

/home/runner/work/framework/framework/src/Illuminate/Database/Concerns/ManagesTransactions.php:120
/home/runner/work/framework/framework/src/Illuminate/Database/Concerns/ManagesTransactions.php:100
/home/runner/work/framework/framework/tests/Database/DatabaseConnectionTest.php:158

[driesvints]

No worries about the above. We fixed the test which probably was incorrect to begin with. Thanks for your work!

[jaapio]

This was definitely a broken test. The mocked method in question was called to many times internally. Although phpunit didn't report this.