Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Method Annotation handling #3803

Closed
wants to merge 1 commit into from
Closed

Fix Test Method Annotation handling #3803

wants to merge 1 commit into from

Conversation

abloemert
Copy link

Make sure annotations from traits are correctly merged and also include missing annotations from parent classes.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #3803 into 7.5 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                7.5    #3803      +/-   ##
============================================
+ Coverage     83.37%   83.38%   +<.01%     
- Complexity     3649     3650       +1     
============================================
  Files           143      143              
  Lines          9728     9733       +5     
============================================
+ Hits           8111     8116       +5     
  Misses         1617     1617
Impacted Files Coverage Δ Complexity Δ
src/Util/Test.php 93.77% <100%> (+0.06%) 218 <0> (+1) ⬆️
src/Runner/Version.php 66.66% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79c053...bd2bf0c. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #3803 into 7.5 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                7.5    #3803      +/-   ##
============================================
+ Coverage     83.37%   83.38%   +<.01%     
- Complexity     3649     3650       +1     
============================================
  Files           143      143              
  Lines          9728     9733       +5     
============================================
+ Hits           8111     8116       +5     
  Misses         1617     1617
Impacted Files Coverage Δ Complexity Δ
src/Util/Test.php 93.77% <100%> (+0.06%) 218 <0> (+1) ⬆️
src/Runner/Version.php 66.66% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79c053...75c79fb. Read the comment docs.

Make sure annotations from traits are correctly merged and also include missing annotations from parent classes.
@abloemert abloemert changed the title Improve Test Method Annotation handling Fix Test Method Annotation handling Sep 2, 2019
@sebastianbergmann sebastianbergmann added the event/code-sprint/2019-09 PHPUnit Code Sprint: September 2019 label Sep 6, 2019
@sebastianbergmann
Copy link
Owner

Can you please provide one or more test cases for this? Thanks!

@sebastianbergmann sebastianbergmann removed the event/code-sprint/2019-09 PHPUnit Code Sprint: September 2019 label Sep 7, 2019
@sebastianbergmann
Copy link
Owner

Can you please verify that this is still relevant after the refactoring that @Ocramius did in #3836? Thanks!

@sebastianbergmann sebastianbergmann added the status/waiting-for-feedback Waiting for feedback from original reporter label Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Waiting for feedback from original reporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants