Do not ignore constructor arguments based on type being mocked

[morozov]

Currently, it is impossible to mock the message or code on a Trowable. On the one hand, getMessage() and getCode() are final in Exception, on the other, the mock generator ignores constructor arguments if the type being mocked is an interface.

The existing behavior doesn't seem correct because on the one hand, PHP currently allows passing more arguments than the method expects (including class constructors). On the other, if it stops doing so at some point later, it should be a test error, not the PHPUnit's call to ignore the arguments.

[codecov]

Codecov Report

Merging #3694 into 7.5 will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                7.5    #3694      +/-   ##
============================================
- Coverage     83.37%   83.36%   -0.01%     
+ Complexity     3647     3645       -2     
============================================
  Files           143      143              
  Lines          9713     9711       -2     
============================================
- Hits           8098     8096       -2     
  Misses         1615     1615

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/MockObject/Generator.php	86.41% <100%> (-0.07%)	139 <0> (-2)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de00854...278379a. Read the comment docs.

[sebastianbergmann]

Just curious: in what scenario does stubbing/mocking Throwable or Exception make sense? I have never though about this before the recent patches, much less needed it.

[morozov]

In doctrine/dbal, we have some logic of handling/generalizing driver exceptions based on their properties. We do not mock Throwable or Exception directly but we do mock interface DriverException extends Throwable.

[sebastianbergmann]

Can you point me to a test that does this? Thanks!

[morozov]

See Doctrine\Tests\DBAL\Driver\AbstractDriverTest::testConvertsException() for example. Right now, we implement the mock using an anonymous class but I'd like to rework it using PHPUnit mocks in doctrine/dbal#3546.