Enhancement: Allow to order tests by time (duration) #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/time
branch
from
586856a to
7843b24
Compare
localheinz
commented
Sep 8, 2018
src/Runner/TestSuiteSorter.php
Outdated
| /** | ||
| * @var int | ||
| */ | ||
| public const ORDER_TIME = 4; |
There was a problem hiding this comment.
Maybe rename this to ORDER_DURATION?
There was a problem hiding this comment.
ORDER_EXECUTION_TIME maybe?
There was a problem hiding this comment.
Yes, DURATION would be nicer as the word time also pops up in e.g. START_TIME and END_TIME. Just a small thing :)
There was a problem hiding this comment.
ORDER_DURATION it is then :-) Thanks!
localheinz
force-pushed
the
feature/time
branch
3 times, most recently
from
250287c to
92bbfb2
Compare
localheinz
force-pushed
the
feature/time
branch
from
92bbfb2 to
9dbcf9e
Compare
|
@epdenouden @sebastianbergmann Shall I update documentation somewhere? |
|
@localheinz The documentation needs a good look re: the execution order changes anyway. I didn't add documentation for my stuff yet, apologies. Only recently got the documentation generator running here. |
|
Thank you, @epdenouden and @sebastianbergmann! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #3284.
💁♂️ Hope I'm not stepping on anyone's toes. Not sure, maybe I should add more test cases, what do you think, @epdenouden?