Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatching posix chars when using colors #949

Closed
stof opened this issue Jun 27, 2013 · 7 comments
Closed

Mismatching posix chars when using colors #949

stof opened this issue Jun 27, 2013 · 7 comments
Assignees

Comments

@stof
Copy link
Contributor

stof commented Jun 27, 2013

Looking at the outpyt, it seems like some POSIX color control chars are mismatching for the testsuite summary (OK (18 tests, 40 assertions)) and the code coverage report summary. the green background color fills the next (empty) line too.

and when running the same testsuite on travis, these 2 parts of the output disappear, which I suspect is related to a stricter parsing of the output. You can see it on https://travis-ci.org/Incenteev/IncenteevTranslationCheckerBundle/jobs/8498973

@whatthejeff
Copy link
Contributor

Sounds like your terminal emulator doesn't support background color erase. I think it's a similar situation for travis.

@whatthejeff
Copy link
Contributor

For the record, I wouldn't mind removing the background color erase sequences so that our output will look better on more emulators (especially travis). The only thing that would change is the background color wouldn't stretch to the end of the window like it does here:

bgcolor

If @sebastianbergmann agrees, I should have time to do this in the next couple of days.

@sebastianbergmann
Copy link
Owner

Sure, go ahead.

@sebastianbergmann
Copy link
Owner

What about sebastianbergmann/php-code-coverage#174?

@whatthejeff
Copy link
Contributor

I should have time for that one later today.

@whatthejeff
Copy link
Contributor

Alright, this should be better now. I've included some before and after screenshots below. Feedback is appreciated:

Black on white before:

screen shot 2013-07-10 at 9 34 42 am

Black on white after:

screen shot 2013-07-10 at 9 38 05 am

Green on black before:

screen shot 2013-07-10 at 9 35 00 am

Green on black after:

screen shot 2013-07-10 at 9 36 41 am

@whatthejeff
Copy link
Contributor

Also, here's an example of what code coverage looks like on travis now: https://travis-ci.org/sebastianbergmann/php-code-coverage/jobs/8926881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants