Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TestCase::iniSet() #5214

Closed
sebastianbergmann opened this issue Feb 19, 2023 · 3 comments
Closed

Deprecate TestCase::iniSet() #5214

sebastianbergmann opened this issue Feb 19, 2023 · 3 comments
Assignees
@sebastianbergmann
Labels
type/deprecation Something will be/is deprecated
Milestone
PHPUnit 11.0

Comments

@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Feb 19, 2023 •
edited
Loading

  • soft deprecation in PHPUnit 10.3 (add @deprecated annotation to the method declaration)
  • deprecation in PHPUnit 11 (using the method will trigger a deprecation)
  • removal in PHPUnit 12
@sebastianbergmann sebastianbergmann added the type/deprecation Something will be/is deprecated label Feb 19, 2023
@sebastianbergmann sebastianbergmann added this to the PHPUnit 11.0 milestone Feb 19, 2023
@sebastianbergmann sebastianbergmann self-assigned this Feb 19, 2023
@sebastianbergmann sebastianbergmann mentioned this issue Feb 19, 2023
Closed
@sebastianbergmann sebastianbergmann changed the title Deprecate TestCase::iniSet() Deprecate TestCase::iniSet() Mar 6, 2023
sebastianbergmann added a commit that referenced this issue Jun 24, 2023
@sebastianbergmann
Soft-deprecate TestCase::iniSet() for #5214
eae2eeb
@derrabus
Copy link
Contributor

derrabus commented Aug 8, 2023

What is the recommended course of action for a codebase that uses this feature currently?

@sebastianbergmann
Copy link
Owner Author

Use ini_get() to get the current value, use ini_set() to set the value you need, use ini_set() to restore.

@derrabus
Copy link
Contributor

derrabus commented Aug 8, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
type/deprecation Something will be/is deprecated
Projects
None yet
Milestone
PHPUnit 11.0
Development

No branches or pull requests
2 participants
@sebastianbergmann @derrabus