PHPUnit and Generators

[live627]

#1174 is still an issue. The offending code seems to be in 4.xx, 5.xx, and master.

The example test in that thread still applies.

[sebastianbergmann]

Copied here from #1174:

<?php
class GeneratorTest extends PHPUnit_Framework_TestCase
{
    public static function generator($range)
    {
        foreach (range(0, $range) as $x) {
            yield $x;
        }
    }

    public function testCountingAGeneratorFailsWithPHPWarning()
    {
        $this->assertCount(10, self::generator(10));
    }
}

$ phpunit GeneratorTest
PHPUnit 5.3.2-7-g3e6974d by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 18 ms, Memory: 4.00Mb

There was 1 error:

1) GeneratorTest::testCountingAGeneratorFailsWithPHPWarning
Exception: Cannot rewind a generator that was already run

/home/sb/GeneratorTest.php:13

FAILURES!
Tests: 1, Assertions: 1, Errors: 1.

[keradus]

I encounter this again.
With the following change: keradus/PHP-CS-Fixer@fbbc8c1
the $this->assertSame('somefile.php', $iterator->current()->getFilename()); fails on HHVM.
If I use assertSame instead of assertCount everything is working on HHVM.

[Nessworthy]

Cause is here:
https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/Constraint/Count.php#L69
Generators cannot be rewound, but assertCount will try and rewind it to its original state if it can because it only sees it as an Iterator.

Sooo, possible solutions are to either add in a case for generators so the rewind call is skipped (as previously suggested), or add new assertions which specifically target generators.

Thoughts?

[sebastianbergmann]

Closed via 4123b6a.