Skip to content

Commit

Permalink
Closes #2300
Browse files Browse the repository at this point in the history
  • Loading branch information
@sebastianbergmann
sebastianbergmann committed Sep 22, 2016
1 parent a270f42 commit d99e588
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion .gitattributes
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
/build export-ignore
/build* export-ignore
/*.md export-ignore
/LICENSE export-ignore
/*.xml export-ignore
/*.xsd export-ignore
/tests export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/.php_cs export-ignore
/.travis.yml export-ignore

*.php diff=php

4 comments on commit d99e588

@remicollet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds terrible :(

  • LICENSE seems mandatory
  • *md seems really important

And tests.... well nobody cares about tests, so perhaps nobody cares about PHPUnit

Please DON'T try to fix a composer bug using .gitattributes. All other installers in all languages (cpan, mvm, pip... even pear) are able to manage file "role", excepted composer.

@GrahamCampbell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should for sure keep the license.

@sebastianbergmann
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remicollet Reverted. As I wanted to do before tagging 5.5.6.

@remicollet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Please sign in to comment.