Closes #5243

sebastianbergmann · Oct 13, 2023 · b4a3672 · b4a3672
1 parent 91dcea7
commit b4a3672
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/ChangeLog-11.0.md b/ChangeLog-11.0.md
@@ -12,6 +12,7 @@ All notable changes of the PHPUnit 11.0 release series are documented in this fi
 ### Deprecated
 
 * [#5241](https://github.com/sebastianbergmann/phpunit/issues/5241): `TestCase::getMockForAbstractClass()` (this method was already [soft-deprecated](https://phpunit.de/backward-compatibility.html#soft-deprecation) in PHPUnit 10)
+* [#5243](https://github.com/sebastianbergmann/phpunit/issues/5243): `TestCase::getMockForTrait()` (this method was already [soft-deprecated](https://phpunit.de/backward-compatibility.html#soft-deprecation) in PHPUnit 10)
 * [#5472](https://github.com/sebastianbergmann/phpunit/issues/5472): `assertStringNotMatchesFormat()` and `assertStringNotMatchesFormatFile()` (these methods were already [soft-deprecated](https://phpunit.de/backward-compatibility.html#soft-deprecation) in PHPUnit 10)
 
 ### Removed

diff --git a/DEPRECATIONS.md b/DEPRECATIONS.md
@@ -12,7 +12,6 @@ This functionality is currently [soft-deprecated](https://phpunit.de/backward-co
 |-------------------------------------------------------------------|---------------------------------------------------|--------|-----------------------------------------------------------------------------------------|
 | [#5240](https://github.com/sebastianbergmann/phpunit/issues/5240) | `TestCase::createTestProxy()`                     | 10.1.0 |                                                                                         |
 | [#5242](https://github.com/sebastianbergmann/phpunit/issues/5242) | `TestCase::getMockFromWsdl()`                     | 10.1.0 |                                                                                         |
-| [#5243](https://github.com/sebastianbergmann/phpunit/issues/5243) | `TestCase::getMockForTrait()`                     | 10.1.0 |                                                                                         |
 | [#5244](https://github.com/sebastianbergmann/phpunit/issues/5244) | `TestCase::getObjectForTrait()`                   | 10.1.0 |                                                                                         |
 | [#5305](https://github.com/sebastianbergmann/phpunit/issues/5305) | `MockBuilder::getMockForAbstractClass()`          | 10.1.0 |                                                                                         |
 | [#5306](https://github.com/sebastianbergmann/phpunit/issues/5306) | `MockBuilder::getMockForTrait()`                  | 10.1.0 |                                                                                         |
@@ -87,3 +86,4 @@ This functionality is currently [hard-deprecated](https://phpunit.de/backward-co
 | Issue                                                             | Description                                    | Since  | Replacement |
 |-------------------------------------------------------------------|------------------------------------------------|--------|-------------|
 | [#5241](https://github.com/sebastianbergmann/phpunit/issues/5241) | `TestCase::getMockForAbstractClass()`          | 10.1.0 |             |
+| [#5243](https://github.com/sebastianbergmann/phpunit/issues/5243) | `TestCase::getMockForTrait()`                  | 10.1.0 |             |
diff --git a/src/Framework/TestCase.php b/src/Framework/TestCase.php
@@ -1435,6 +1435,11 @@ final protected function getMockFromWsdl(string $wsdlFile, string $originalClass
      */
     final protected function getMockForTrait(string $traitName, array $arguments = [], string $mockClassName = '', bool $callOriginalConstructor = true, bool $callOriginalClone = true, bool $callAutoload = true, array $mockedMethods = [], bool $cloneArguments = false): MockObject
     {
+        Event\Facade::emitter()->testTriggeredPhpunitDeprecation(
+            $this->valueObjectForEvents(),
+            'getMockForTrait() is deprecated and will be removed in PHPUnit 12. No replacement is/will be provided.',
+        );
+
         $mockObject = (new MockGenerator)->mockObjectForTrait(
             $traitName,
             $arguments,

diff --git a/tests/unit/Framework/MockObject/Creation/GetMockForTraitTest.php b/tests/unit/Framework/MockObject/Creation/GetMockForTraitTest.php
@@ -10,6 +10,7 @@
 namespace PHPUnit\Framework\MockObject;
 
 use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\Attributes\IgnorePhpunitDeprecations;
 use PHPUnit\Framework\Attributes\Medium;
 use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\MockObject\Generator\UnknownTraitException;
@@ -21,6 +22,7 @@
 #[Group('test-doubles/mock-object')]
 #[Medium]
 #[TestDox('getMockForTrait()')]
+#[IgnorePhpunitDeprecations]
 final class GetMockForTraitTest extends TestCase
 {
     public function testCreatesMockObjectForTraitAndAllowsConfigurationOfAbstractMethods(): void