Skip to content

Commit

Permalink
Update Project.toml
Browse files Browse the repository at this point in the history
  • Loading branch information
RafaelArutjunjan committed Apr 28, 2023
1 parent 8cb4dc7 commit a857de5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
[compat]
CSV = "0.10"
ChainRulesCore = "1"
DataFrames = "0.2 - 1.5"
DataFrames = "1.0, 1.1, 1.2, 1.3, 1.4, 1.5"
DiffEqCallbacks = "2"
Distributions = "0.21 - 0.25"
FiniteDifferences = "0.11, 0.12"
ForwardDiff = "0.10"
ModelingToolkit = "6 - 8"
NonlinearSolve = "0.6 - 1.6"
NonlinearSolve = "1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6"
OrdinaryDiffEq = "6"
PreallocationTools = "0.4"
PyCall = "1"
Expand Down
2 changes: 1 addition & 1 deletion src/Create_PEtab_ODEProblem.jl
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ function setupPEtabODEProblem(petabModel::PEtabModel,
elseif gradientMethod === :Adjoint
@assert (typeof(sensealg) <: SciMLSensitivity.AbstractAdjointSensitivityAlgorithm) "For adjoint sensitivity analysis allowed sensealg are InterpolatingAdjoint() or QuadratureAdjoint()"
elseif gradientMethod === :Zygote
@assert (typeof(sensealg) <: SciMLSensitivity.AbstractSensitivityAlgorithm) "For Zygote an abstract sensitivity algorithm from SciMLSensitivity must be used"
@assert (typeof(sensealg) <: SciMLBase.AbstractSensitivityAlgorithm) "For Zygote an abstract sensitivity algorithm from SciMLSensitivity must be used"
end
odeProblemGradient = gradientMethod === :ForwardEquations ? getODEProblemForwardEquations(odeProblem, sensealg) : getODEProblemForwardEquations(odeProblem, :NoSpecialProblem)
# ssSolverGradient defaults to the same options as for the cost, but with tolerances set in relation to gradient ODE solver
Expand Down
14 changes: 7 additions & 7 deletions test/Test_model2.jl
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ include(joinpath(@__DIR__, "Common.jl"))

"""
testOdeSol(solver, tol; printRes=false)
Compare analytical vs numeric ODE solver using a provided solver with
tolerance tol for the Test_model2.
Returns true if passes test (sqDiff less than 1e-8) else returns false.
Compare analytical vs numeric ODE solver using a provided solver with
tolerance tol for the Test_model2.
Returns true if passes test (sqDiff less than 1e-8) else returns false.
"""
function testODESolverTestModel2(petabModel::PEtabModel, solverOptions)

Expand Down Expand Up @@ -118,10 +118,10 @@ end

"""
testCostGradientOrHessianTestModel2(solver, tol; printRes::Bool=false)
Compare cost, gradient and hessian computed via the analytical solution
vs the PeTab importer functions (to check PeTab importer) for five random
parameter vectors for Test_model2. For the analytical solution the gradient
and hessian are computed via ForwardDiff.
Compare cost, gradient and hessian computed via the analytical solution
vs the PeTab importer functions (to check PeTab importer) for five random
parameter vectors for Test_model2. For the analytical solution the gradient
and hessian are computed via ForwardDiff.
"""
function testCostGradientOrHessianTestModel2(petabModel::PEtabModel, solverOptions)

Expand Down

2 comments on commit a857de5

@RafaelArutjunjan
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/81608

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.0.0 -m "<description of version>" a857de570f493a08c2899d74037d1e84f9616b1b
git push origin v1.0.0

Please sign in to comment.