Skip to content

Commit

Permalink
[chore](function) Refactor FunctionSet Initialization for Better Main…
Browse files Browse the repository at this point in the history
…tainability and Compilation Success (apache#20285)

In this PR, I have refactored the initialization of the FunctionSet. Previously, all the functions were in one large method which led to the generation of Java code that was too long. This posed a problem for the compiler, as the length of the method exceeded the limit imposed by the Java compiler.

To resolve this issue and improve the readability and manageability of our code, I have categorized these functions by type, and created dedicated initialization methods for each type. As such, our code is now not only more readable and understandable, but also each method is of a length that is acceptable to the compiler and can be compiled successfully.

Moreover, this change makes it easier for us to add new functions as we can directly locate the right category and add new functions there.

This is a significant change aimed at enhancing the maintainability and scalability of our code, while ensuring that our code can be successfully compiled.
  • Loading branch information
zy-kkk authored and pull[bot] committed Nov 30, 2023
1 parent 82f8962 commit df5c576
Show file tree
Hide file tree
Showing 2 changed files with 1,905 additions and 1,850 deletions.
Loading

0 comments on commit df5c576

Please sign in to comment.