-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swarm csi #173
Swarm csi #173
Conversation
deploy/swarm/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file mostly duplicates content in cmd/seaweedfs-csi-driver/swarm/README.md
maybe just remove this, or add a reference to the other file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
Can you do this?
Thanks for this PR! In later PRs, I wonder whether there are some way to add an integration test for this, similar to https://github.com/seaweedfs/seaweedfs/blob/master/.github/workflows/e2e.yml , which can also serve as a usage example. |
I will delete my fork. About e2e Test. Thank you for this Project, I am using seaweed in my Cluster, and I am pretty happy with it! If I can contribute more, I will. One thing that I see is that the log output of the plugin appears as errors in docker logs. can this be adjusted? |
Yes. That would be nice. I do not know much here though.
Yes. |
please note that in docker 27.x.x CSI plugin interface is broken |
@blib You are right. |
it's not a seaweedfs problem. I submitted PR moby/swarmkit#3181 you can up vote it :) |
@blib Ah thank you for the correction, i got that wrong then. |
Build scripts and Documentation for docker Swarm CSI.