Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor faculty creation to use subscribers for absence creation #625

Open
rmainwork opened this issue Jan 12, 2023 · 0 comments
Open

Refactor faculty creation to use subscribers for absence creation #625

rmainwork opened this issue Jan 12, 2023 · 0 comments
Labels
Server Code on the server side of the application Technical Debt Code requires cleanup

Comments

@rmainwork
Copy link
Contributor

Description

When creating new faculty members, the absences are (currently) created in the controller. This should probably be moved to a subscriber to be more in-keeping with the TypeORM way of doing things as well as providing a better guarantee that creating a new faculty member will always create the appropriate absences (rather than having to rely on the controller doing it correctly for us)
@rmainwork rmainwork added bug/broken functionality Something isn't working Technical Debt Code requires cleanup Server Code on the server side of the application labels Jan 12, 2023
rmainwork pushed a commit that referenced this issue Jan 12, 2023
Replace typeorm subscriber with controller code
6962b1f 
In order to expidite the patching of the bug, the subscriber has been replaced
with code in the Nest controller. This is due to the fact that changes to how
records are created would have knock-on impacts on the population service and
ETL script which would potentially take time to patch and review.

Therefore, #625 has been opened to track this tech debt and will be revisited
at a later time
@jonseitz jonseitz removed the bug/broken functionality Something isn't working label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Server Code on the server side of the application Technical Debt Code requires cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonseitz @rmainwork