You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As things currently stand, the course instance table
and the Non-class meetings table
are essentially the same thing,. but are implemented as separate components.
Ideally, they should be refactored into one generic re-usable component (similar to the current implementation of the course instance table) that can show the columns passed as props. This would allow us to have tests for only one implementation of the complex table layout, and keep the logic for it in one place(as well as only having to test it once).
Perhaps an array of columns could be provided, with offset numbers for the start and end of the fall/spring header columns to determine which columns they sit above on the table.
<SemesterTablecolumns={/* some array of column data goes here (maybe reformatted table data?) */}fallColumnStart={/* the first column number that should be considered part of "Fall <academic year> -1 "*/}fallColumnEnd={/* the last column number that should be considered part of "Fall <academic year> -1 "*/}springColumnStart={/* the first column number that should be considered part of "Spring <academic year>"*/}springColumnEnd={/* the last column number that should be considered part of "Spring <academic year>"*/}// ... Other props/>
The text was updated successfully, but these errors were encountered:
The non-class meetings table was copied from the course-instance table
however, since the non-class meetings table is static and the columns do
not change - much of that functionality was stripped out and the columns
hard coded
In future we may wish to re-use the fancy dynamic column table to save
on testing and debugging. More on that in #362
Refactor NonClassMeetings table to import the meeting layout components
from the course instances table.
In future, both the non-class meetings table and the course instances
table should be refactored to generalize the components used within.
This work will be done in #362, but for the time being the non-class
meetings table has just been changed to import the components from the
course instances directory
As things currently stand, the course instance table
and the Non-class meetings table
are essentially the same thing,. but are implemented as separate components.
Ideally, they should be refactored into one generic re-usable component (similar to the current implementation of the course instance table) that can show the columns passed as props. This would allow us to have tests for only one implementation of the complex table layout, and keep the logic for it in one place(as well as only having to test it once).
Perhaps an array of columns could be provided, with offset numbers for the start and end of the fall/spring header columns to determine which columns they sit above on the table.
The text was updated successfully, but these errors were encountered: