Set retry limit on the DB #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sears
requested changes
Aug 19, 2021
| @@ -60,6 +60,8 @@ | |||
| private static final String EXTERNAL_CLIENT_DIRECTORY_DEFAULT = "."; | |||
| private static final String TRACE_DIRECTORY = "foundationdb.tracedirectory"; | |||
| private static final String TRACE_DIRECTORY_DEFAULT = ""; | |||
| private static final String RETRY_LIMIT = "foundationdb.retrylimit"; | |||
| private static final String RETRY_LIMIT_DEFAULT = "5"; | |||
There was a problem hiding this comment.
This should default to zero (retry forever). FDB often goes unavailable for minutes at a time during load, which would create holes in the keyspace. In turn, it's likely that YCSB's verify will notice, and declare the database corrupted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the FDB DB object will retry a transaction indefinitely. That behavior can cause a YCSB run to hang when the database become unavailable. In particular, the continued traffic from the retries can interfere with the cluster's ability to recover. This change adds a parameter that limits how many retries are used for every transaction, which defaults to 5.