-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not use netplan to create team0 #639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupremathieu
force-pushed
the
do_not_use_netplan_to_create_team0
branch
7 times, most recently
from
December 5, 2024 08:47
e37d8a0
to
dfa7228
Compare
eroussy
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message :
To avoid a bug on Netplan during OVS cleanup step that resets
eroussy
requested changes
Dec 5, 2024
dupremathieu
force-pushed
the
do_not_use_netplan_to_create_team0
branch
from
December 5, 2024 13:31
dfa7228
to
431fc74
Compare
dupremathieu
force-pushed
the
do_not_use_netplan_to_create_team0
branch
2 times, most recently
from
December 5, 2024 13:44
5b0ac4b
to
97c8f14
Compare
eroussy
requested changes
Dec 5, 2024
dupremathieu
force-pushed
the
do_not_use_netplan_to_create_team0
branch
from
December 5, 2024 16:47
97c8f14
to
d701a62
Compare
eroussy
previously approved these changes
Dec 6, 2024
dupremathieu
force-pushed
the
do_not_use_netplan_to_create_team0
branch
from
December 6, 2024 12:02
d701a62
to
fe2e4c1
Compare
To avoid a bug on Netplan during OVS cleanup step that reset the RSTP configuration of the bridge that is already configured, we decided not to use Netplan to create the team0 interface. The team0 bridge is now created in anycase by the systemd-networkd. Signed-off-by: Mathieu Dupré <[email protected]>
dupremathieu
force-pushed
the
do_not_use_netplan_to_create_team0
branch
2 times, most recently
from
December 6, 2024 12:36
30ef9cb
to
e2c7d9f
Compare
eroussy
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a bug on Netplan during OVS cleanup step that reset the RSTP configuration of the bridge that is already configured, we decided not to use Netplan to create the team0 interface.
The team0 bridge is now created in anycase by the systemd-networkd.