Correct network playbook reboot debian #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the timemaster configuration has changed, it could mean the ptp interface has changed. In that case, we need to reload systemd. Signed-off-by: Erwann Roussy <[email protected]>
The timemaster service could use interfaces defined during the systemd-network role run. A reload of systemd-network only happen if the variable `apply_network_config` is set to true. Thus, the restart of the timemaster service must only happen if the variable `apply_network_config` is set to true. Signed-off-by: Erwann Roussy <[email protected]>
Apply the last commit of ansible-role-systemd-networkd. Pass the variable `systemd_networkd_apply_config` to it. With this modification, the hypervisor will reboot (or reload systemd-networkd) if network configuration has changed. Signed-off-by: Erwann Roussy <[email protected]>
This case is already handled by the systemd-network role Signed-off-by: Erwann Roussy <[email protected]>
Virtual Machines don't need to reboot and can apply their network config directly in the playbook. This commit avoids the use of `apply_network_config` in the VM inventory by putting it to true directly in the playbook. Signed-off-by: Erwann Roussy <[email protected]>
eroussy
force-pushed
the
correct_network_playbook_reboot_debian
branch
2 times, most recently
from
b72689f to
c48e5c9
Compare
udev needs to be restarted when link files are added. It is better to do that in the systemd-neworkd role than directly in the profile. Signed-off-by: Erwann Roussy <[email protected]>
- Network changes made on VMs don't need to reboot - Standalone machines will be rebooted at the end of the cluster_setup_debian.yaml playbook, just after network. Signed-off-by: Erwann Roussy <[email protected]>
Remove the network implementation variables of the examples and add them to the README. These variables should not be used by SEAPATH beginners, thus they should not be mentionned in the examples. Signed-off-by: Erwann Roussy <[email protected]>
The URL was not the right one. Signed-off-by: Erwann Roussy <[email protected]>
eroussy
force-pushed
the
correct_network_playbook_reboot_debian
branch
from
c48e5c9 to
518a42e
Compare
Paullgk
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reload systemd-network only when the configuration has changed.
Correct a bug where timemaster could wait for a interface that would be created later in the playbook.