Refactor Rejection system #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
refactor-rejections
branch
from
02dbc35
to
f2b1c56
Compare
- Improved performance of "known" rejections, by not needing to store them as `Box<dyn std::error::Error>` in order to satisfy `Rejection::cause()`. - `reject::custom()` no longer requires `std::error::Error`, just `Reject + Debug`. This should make it less annoying to construct new custom rejections. - Removed deprecated features: - `Rejection::cause()` - `Rejection::into_cause()` - `Rejection::status()` - `Rejection::with()` - `Rejection::json()` - `impl Serialize for Rejection` - `reject::bad_request()` - `reject::forbidden()` - `reject::server_error()` - Removed `path::param2()`.
seanmonstar
force-pushed
the
refactor-rejections
branch
from
f2b1c56
to
f61f3fd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
them as
Box<dyn std::error::Error>in order to satisfyRejection::cause().reject::custom()no longer requiresstd::error::Error, justReject + Debug. This should make it less annoying to construct newcustom rejections.
Rejection::cause()Rejection::into_cause()Rejection::status()Rejection::with()Rejection::json()impl Serialize for Rejectionreject::bad_request()reject::forbidden()reject::server_error()path::param2().