Add CRLs to rustls feature #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksenia-vazhdaeva
force-pushed
the
rustls-crl
branch
from
059c542
to
03ee65a
Compare
ksenia-vazhdaeva
force-pushed
the
rustls-crl
branch
from
03ee65a
to
b8e7562
Compare
seanmonstar
requested changes
Sep 30, 2024
src/lib.rs
Outdated
| @@ -349,6 +349,8 @@ if_hyper! { | |||
| #[cfg(feature = "__tls")] | |||
| // Re-exports, to be removed in a future release | |||
| pub use tls::{Certificate, Identity}; | |||
| #[cfg(feature = "__rustls")] | |||
| pub use tls::Crl; | |||
There was a problem hiding this comment.
Since the other re-exports will be removed from the top-level eventually, we probably shouldn't add this one. People should reach for it from reqwest::tls::....
There was a problem hiding this comment.
You are right. Thank you. I will fix this.
|
@seanmonstar thank you very much for the review! I hope that this PR will be useful for others. I replied to your comments. |
|
@seanmonstar could you, please, review PR after suggested changes? |
seanmonstar
reviewed
Oct 15, 2024
|
@seanmonstar , thank you! |
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Oct 29, 2024
⚠️ Dependabot is rebasing this PR⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. Bumps reqwest from 0.12.8 to 0.12.9. Release notes Sourced from reqwest's releases. v0.12.9 What's Changed Add tls::CertificateRevocationLists support (by @ksenia-vazhdaeva in seanmonstar/reqwest#2433) Add crate features to enable webpki roots without selecting a rustls provider (by @stevefan1999-personal in seanmonstar/reqwest#2447) Fix multipart::Part::file() to automatically include content-length (by @Mr-Pine in seanmonstar/reqwest#2459) Fix proxy to internally no longer cache system proxy settings (by @lanyeeee in seanmonstar/reqwest#2442) Fix connection_verbose() to output read logs (by @seanmonstar in seanmonstar/reqwest#2454) New Contributors @lanyeeee made their first contribution in seanmonstar/reqwest#2442 @ksenia-vazhdaeva made their first contribution in seanmonstar/reqwest#2433 @Mr-Pine made their first contribution in seanmonstar/reqwest#2459 @stevefan1999-personal made their first contribution in seanmonstar/reqwest#2447 Full Changelog: seanmonstar/[email protected] Changelog Sourced from reqwest's changelog. v0.12.9 Add tls::CertificateRevocationLists support. Add crate features to enable webpki roots without selecting a rustls provider. Fix connection_verbose() to output read logs. Fix multipart::Part::file() to automatically include content-length. Fix proxy to internally no longer cache system proxy settings. Commits 797df2b v0.12.9 64aa7d1 add webpki roots option for rustls no provider setup (#2447) 598f857 Add content length to async_impl::multipart file streams (#2459) d99e90d fix: re-enable verbose connection read logs (#2454) aba01ff feat: Add support for Certificate Revocation Lists (#2433) 3ad6e02 refactor: remove internal proxy sys cache (#2442) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
Currently requires rustls backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.