Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout testing #2418

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

Hyask
Copy link
Contributor

@Hyask Hyask commented Sep 11, 2024

Two patches that make the timeout tests to pass in the Ubuntu CI infrastructure:

  • Ignore the proxy.
  • Use a reserved address space that is more guaranteed not to be routable.

Details and explanations are in each commit log.

If an explicit proxy is configured in the environment, the timeout tests
will actually go through it, and then the test results will depend on
the proxy's performance, which can vary.

Testing this is very simple:
```
export http_proxy="http://127.0.0.1:1234"
cargo test timeouts
```

We're hitting this issue in the Ubuntu CI. Further investigations
after 892569e seemed to point that
**sometimes**, the proxy would be too slow (particularly on non amd64
architectures), leading to the tests to actually timeout and pass.
10.255.255.0/24 is part of 10.0.0.0/8 and reserved for "Private Use" by
IANA [1]. That means that those IP might be in use in some internal
networks, making the timeout tests to fail on those networks.
One example of such network is the Ubuntu testing infrastructure.

Changing for a documented "Test network", that is supposed to never be
routable [2] makes the tests to have a better chance to pass in most
network contexts.

[1]: https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml
[2]: https://www.rfc-editor.org/rfc/rfc5737.html
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar
Copy link
Owner

Also, we could add a "private" cargo feature that disables checking the environment for proxies to be used in tests. There's already 1 that used to skip caching the env parsing, meant only for CI.

@seanmonstar seanmonstar merged commit c8665be into seanmonstar:master Sep 12, 2024
36 checks passed
@Hyask
Copy link
Contributor Author

Hyask commented Sep 12, 2024

Thanks for merging! As for the private cargo feature, well, I don't really have an opinion. If you want to try something and wonder how it would fit in Ubuntu's CI, feel free to ping, I can help with some testing :-)

kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Oct 1, 2024
Bumps reqwest from 0.12.7 to 0.12.8.

Release notes
Sourced from reqwest's releases.

v0.12.8
What's Changed

Add support for SOCKS4 proxies.
Add multipart::Form::file() method for adding files easily.
Add Body::wrap() to wrap any http_body::Body type.
Fix the pool configuration to use a timer to remove expired connections.

New Contributors

@​workingjubilee made their first contribution in seanmonstar/reqwest#2402
@​NaokiM03 made their first contribution in seanmonstar/reqwest#2106
@​Xuanwo made their first contribution in seanmonstar/reqwest#2255
@​Jaltaire made their first contribution in seanmonstar/reqwest#2400
@​Hyask made their first contribution in seanmonstar/reqwest#2418
@​Jake-Shadle made their first contribution in seanmonstar/reqwest#2427
@​RobMor made their first contribution in seanmonstar/reqwest#2434

Full Changelog: seanmonstar/[email protected]



Changelog
Sourced from reqwest's changelog.

v0.12.8

Add support for SOCKS4 proxies.
Add multipart::Form::file() method for adding files easily.
Add Body::wrap() to wrap any http_body::Body type.
Fix the pool configuration to use a timer to remove expired connections.




Commits

95fec09 v0.12.8
baf9712 fix: pass pool_timer to hyper_util to enable the idle cleanup task (#2434)
d85f44b Bump rustls-native-certs (#2427)
c8665be tests: use a documented test network for testing
964b1c6 tests: bypass the proxy when testing timeouts
09884ed feat: Add support for SOCKS4 (#610) (#2400)
a13a6bc ci: pin tokio-util for msrv job (#2412)
4cc8ec8 feat: Expose streaming as public API wrap (#2255)
cc3dd51 Add file function to async::multipart (#2106)
193ed1f chore: Depend on wasm-bindgen 0.2.89 or higher
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants