Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client certificate support #192

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Add client certificate support #192

merged 1 commit into from
Aug 30, 2017

Conversation

seanmonstar
Copy link
Owner

Closes #43
Closes #176

Maybe? Is Identity too generic of a type name?

@seanmonstar
Copy link
Owner Author

My only hesitation is in the naming. Looking around at other libraries, I don't see any others calling this an Identity. Usually it's named something about "cert". In some cases, it's overloaded, such that cert really means cert + key + password, and in others, cert, key, and password options are set individually.

I kind of feel like neither of the best. A client certificate is more than just the cert, but it needs all 3, not optionally some of them. The latter concern is covered by this being a single type, like Identity. It would seem weird to call this a Certificate, since it's actually more than that. Perhaps Identity is the best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant