Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce string allocation during multipart header encoding #1724

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Reduce string allocation during multipart header encoding #1724

merged 1 commit into from
Jan 12, 2023

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Jan 12, 2023

The headers are written directly into a single Vec instead of using format!.

seanmonstar
seanmonstar approved these changes Jan 12, 2023
View reviewed changes
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar enabled auto-merge (squash) January 12, 2023 18:53
@seanmonstar seanmonstar merged commit 1d90496 into seanmonstar:master Jan 12, 2023
@nickelc nickelc deleted the multipart-encode-headers branch January 12, 2023 19:09
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
@nickelc @Nutomic
Reduce string allocation during multipart header encoding (seanmonsta…
18b69a8 
…r#1724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickelc @seanmonstar