Fix HTTP/2: retry requests rejected by a graceful shutdown #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
http2-retry-graceful-shutdown
branch
from
5242893 to
8f1f8d5
Compare
seanmonstar
force-pushed
the
http2-retry-graceful-shutdown
branch
from
8f1f8d5 to
9c4b4fb
Compare
|
cc @ry @lucacasonato |
|
This is great Sean, thanks so much for working on this! I have confirmed that this fixes the issue we were running into (at least judging by all of our isolated test cases). I will try it out in production right after this lands in a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server starts a graceful shutdown, and rejects a set of requests, those request futures would return an HTTP/2 error. This patch now inspects the error, and it is specifically an HTTP/2 graceful shutdown, and the request body can be reused, the request will be retried on a different connection. There is a limit of 2 retries just prevent possible infinite loops.
(It turns out writing a test was difficult, since hyper's graceful shutdown isn't flexible enough to select which extra requests to reject. I have verified it fixes what was reported in #1276.)
Closes #1276