Redefine StatusCode in Reqwest

[seanmonstar]

From hyperium/hyper#1196, hyper still has a way to go to become stable, and after discussing trying to stabilize a smaller crate of types, it seems like the best action is to define the type in Reqwest, and in the future use the types from some http crate. This allows us to move Reqwest along, without trying to rush stabilizing an http crate without exploration.

[jimmycuadra]

This would be unfortunate for my use case as I described in hyperium/hyper#894. I am hoping for types that represent the building blocks of HTTP to exist in a crate without a full client implementation.

I'm also not sure I understand how StatusCode could exist in reqwest if it's built on hyper. Does that mean hyper has its own identical StatusCode type?

[seanmonstar]

We all want an http crate. The point here is that the libs team would like to stabilize reqwest to 1.0 sooner than we could probably stabilize a proper http. So, this is the only solution.

For your second question, it's exactly as it sounds. hyper would of course have a StatusCode, but be unstable. Reqwest would never expose it, only showing its own.

[seanmonstar]

Blocked on Rust 1.20, as we want associated constants instead of enum variants.

[mathstuf]

Wouldn't this also mean that reqwest would be stuck with its own even after a hypothetical http crate materialized (though From and Into make it easy, it's still not ideal)?

Though I wouldn't be against a 2.0 at that point either. It would theoretically be source compatible, but everything would still need to agree on the same major version number.

[seanmonstar]

If the types don't change at all during the http stabilization, then it should hopefully be a backwards compatible change to just change to a re-export.

[mathstuf]

I guess Cargo would have issues bridging the types even if two minor versions of reqwest found each other from different crate transitive dependencies anyways, so there's no difference then between a minor or major bump.

[opilar]

Rust 1.20 is stable now. I would like to help. What should be done?

[seanmonstar]

I received some comments from a few on the rust libs team that reqwest should just use the types from the http crate, even though it won't be 1.0 before reqwest. I'm undecided if that's the right thing to do, but welcome other comments.

[KodrAus]

Right now reqwest re-exports the status codes from hyper, right? So does this depend on a new version of hyper that uses http? Otherwise I guess you'd have to convert status codes to and from u16 or something between hyper and reqwest.

[seanmonstar]

No, this wouldn't require a new version of hyper. Eventually hyper will use http types, but before that, one can just convert to hyper's types internally.

[seanmonstar]

There is now the http crate, and 0.9 will depend on it directly, so this isn't needed.