You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In accordance with this API guideline, we like for error types to be Send and Sync. This is less important (or maybe not important) for references to trait objects, but here there doesn't seem to be a reason to want the flexibility of returning a non-Send or -Sync type in the future.
Returning Option<&(std::error::Error + Send + Sync + 'static)> would be consistent with the signature of std::io::Error::get_ref.
The text was updated successfully, but these errors were encountered:
reqwest::Error::get_ref
returnsOption<&(std::error::Error + 'static)>
.In accordance with this API guideline, we like for error types to be Send and Sync. This is less important (or maybe not important) for references to trait objects, but here there doesn't seem to be a reason to want the flexibility of returning a non-Send or -Sync type in the future.
Returning
Option<&(std::error::Error + Send + Sync + 'static)>
would be consistent with the signature ofstd::io::Error::get_ref
.The text was updated successfully, but these errors were encountered: